[patch 2/2] fix idle loop for offline cpu

Nathan Lynch nathanl at austin.ibm.com
Thu Aug 12 04:45:54 EST 2004


On Wed, 2004-08-11 at 13:30, Joel Schopp wrote:
> iSeries is not cpu DLPAR capable in Linux.  The "i5" machine itself is,
> but it is not supported by #define CONFIG_PPC_ISERIES.  You actually run
> the pSeries Linux on it.  Because of this I think it is wasteful to
> check cpu_is_offline here.
>
> Other than that I think both patches are great.
>
> > diff -puN arch/ppc64/kernel/idle.c~ppc64-fix-idle-loop-for-offline-cpu arch/ppc64/kernel/idle.c
> > --- 2.6.8-rc4/arch/ppc64/kernel/idle.c~ppc64-fix-idle-loop-for-offline-cpu	2004-08-11 10:44:29.000000000 -0500
> > +++ 2.6.8-rc4-nathanl/arch/ppc64/kernel/idle.c	2004-08-11 10:44:29.000000000 -0500
> > @@ -132,6 +132,7 @@ int iSeries_idle(void)
> >  int default_idle(void)
> >  {
> >  	long oldval;
> > +	unsigned int cpu = smp_processor_id();
> >

The diff output is confusing -- I did not modify iSeries_idle; the hunk
to which you refer actually changes default_idle, which is used on Power
4 partitions.

Nathan


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list