[PATCH] Fix to update the OP panel on enterting/exiting kdb.
olof at austin.ibm.com
Sat Apr 24 01:32:42 EST 2004
Nitin Vashisth wrote:
> This patch will update the OP panel with the KDB message every time kdb
> is entered and will put back the Linux kernel version string back on the
> panel while exiting KDB.
I'm not so certain that I like this. Sure, it's great to be able to spot
from just glancing at an HMC that a system has entered KDB, but every
time you add more activity to KDB, the greater the risk is that it'll
get stuck itself. For example, the code below will use the RTAS calls to
update the information on the LED display.
Anyway, see other comments below.
> +#ifdef CONFIG_PPC64
> + ppc64_attention_msg(0x3300+cpu,"KDB Done ");
> + ppc_md.progress("Linux ppc64\n", 0);
> + ppc_md.progress(UTS_RELEASE, 0);
Why do you re-print the Linux/UTS_RELEASE string? There's nothing that
really says it has to be there, chances are it's not even there when KDB
is entered in the first place. :)
Also, you have a lot of duplicated code, the same lines repeat over and
over again. If you necessarily have to add this, why not add two small
inline functions somewhere and call them instead? It'll keep the code
Olof Johansson Office: 4F005/905
Linux on Power Development IBM Systems Group
Email: olof at austin.ibm.com Phone: 512-838-9858
All opinions are my own and not those of IBM
** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/
More information about the Linuxppc64-dev