[PATCH] NULL dn->type deref in EEH code (IPR driver)

Nathan Lynch nathanl at austin.ibm.com
Tue Apr 13 03:36:23 EST 2004


linas at austin.ibm.com wrote:
> The IPR driver appearently has NULL for struct device_node *dn->type
> where dn was returned by pci_device_to_OF_node(dev);  I don't know
> if its 'normal' to have a NULL here or not.  Brian King reported
> a crash here in his IPR driver, and this patch works around that.

If a device_node has a "device_type" property, the dn's 'type' field
points to that property's value.  Some device nodes do not have the
property, so the type field is NULL.  So I think the patch is correct.

Nathan

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list