[PATCH] Add KDB Modules support

[linas at austin.ibm.com]

On Thu, Sep 25, 2003 at 03:20:19PM -0500, linas at austin.ibm.com wrote:
>
> On Thu, Sep 25, 2003 at 10:06:08PM +0200, Olaf Hering wrote:
> >  On Thu, Sep 25, linas at austin.ibm.com wrote:
> >
> > >
> > > Warning: On my machine asking for req and rqueue hung the machine hard.
> > > req             <vaddr>              dump request struct
> > > rqueue          <vaddr>              dump request queue
> > >
> > > I suspect that this may be due to the fact that the ppc64 KDB is downlevel,
> > > and that this problem is fixed in newer KDB's.
> >
> > Is that fixable for the currently used KDB?
> > A simple #if 0 might count as a fix.

The following seems to fix the hang, making all of the new commands usable:

--- kdb/modules/kdbm_pg.c.orig  2003-09-25 15:09:53.000000000 -0500
+++ kdb/modules/kdbm_pg.c       2003-09-25 17:12:47.000000000 -0500
@@ -244,7 +244,7 @@ kdbm_rqueue(int argc, const char **argv,
        head_addr = addr + offsetof(struct request_queue, queue_head);
        kdb_printf(" request queue: %s\n", next == head_addr ?
                "empty" : "");
-       while (next != head_addr) {
+       while (next && next != head_addr) {
                i++;
                next = print_request(next);
        }


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/