[PATCH] add new OF device tree API (2.6.0-test3)
linas at austin.ibm.com
linas at austin.ibm.com
Fri Sep 26 05:15:53 EST 2003
On Wed, Sep 24, 2003 at 02:39:57PM -0500, Hollis Blanchard wrote:
>
> On Tuesday, Sep 23, 2003, at 15:22 US/Central, Nathan Lynch wrote:
>
> > Nathan Lynch wrote:
> >> Some things which I plan to add within the next few days:
> >> - "porting" arch/ppc64 to the new API
> >> - implementation of reference counting
> >> - support for addition and removal of device nodes
> >> - a /proc-based mechanism for initiating node addition and removal
> >> from
> >> userspace
> >
> > Attached is a patch which replaces all the uses of the old device tree
> > API in arch/ppc64. Patch is against 2.6.0-test5 (cset 1.1328) from
> > ameslab bk, plus the patch from my previous message. I've tested this
> > on a pSeries LPAR.
>
> Some of the virtual IO code is very dependent on the device tree. It
> would be great if Nathan's code could be reviewed and committed? I
> don't want to code to an obsolete interface, and we'll need this new
> interface anyways for VIO DLPAR.
I don't know if my opinion counts for anything here, but I actually read
the patch and it looked harmless. But that is because it mostly does
nothing other than replace calls to find_path_device() with calls to
of_find_node_by_path() and insserts of_node_put() in reasonable looking
places. So what can go wrong?
I didn't actually read of_find_node_by_path(), however, since its not
in this patch.
--linas
** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/
More information about the Linuxppc64-dev
mailing list