[PATCH][2.4] VIO infrastructure update - review request

John Rose johnrose at austin.ibm.com
Fri Oct 31 03:10:14 EST 2003

Patch looks good.  I have a couple of comments, none of which have any
substance :)

- vio_register_device():  Might it be more clear to accept a struct
  device_node * here rather than a void *?  Is this done for
  portability?  Currently you have to cast the device node * to void *
  when calling, and then cast the void * back to device node once
  inside the function.

- vio_register_device():  First error printk, "UNKNOWN" is missing an
  "N" :)

- vio_find_driver(): You could save a line and a variable by using


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc64-dev mailing list