[PATCH][2.6] JS20 support

dwm at austin.ibm.com dwm at austin.ibm.com
Wed Nov 26 09:27:44 EST 2003


Linas,


  Don't recall exactly, but it seems the issue being resolved in the
  ppc64 case is that just after this point, the code assumes that the
  values of the controller/drive have been set by the BIOS and reported.
  If the value is zero, use the values reported, which are not set,
  and the calling code exits before actually doing anything.  The IDE
  controller is not configured:-/

  Since we don't have a "BIOS", perhaps this should ber a conditional on
  CONFIG_PSERIES.

from the keyboard of linas:
>
>Hi Jake,
>
>
>On Mon, Nov 24, 2003 at 05:12:13PM -0600, Jake Moilanen wrote:
>> diff -Nru a/drivers/ide/pci/amd74xx.c b/drivers/ide/pci/amd74xx.c
>> --- a/drivers/ide/pci/amd74xx.c	Mon Nov 24 14:23:40 2003
>> +++ b/drivers/ide/pci/amd74xx.c	Mon Nov 24 14:23:40 2003
>> @@ -374,7 +374,7 @@
>>  #endif /* DISPLAY_AMD_TIMINGS && CONFIG_PROC_FS */
>>
>>
>> -	return 0;
>> +	return dev->irq;
>>  }
>>
>>  static void __init init_hwif_amd74xx(ide_hwif_t *hwif)
>
>
>FYI, 6 months ago I tried submitting a similar patch for a different
>ide driver.  Alan Cox wrote back to say that doing this was wrong,
>and started talking something about 'legacy ide', and how this would
>break certain older pc's.  I didn't understand the issue.  So just
>be forwarned. Maybe Doug Maxey understands the issue?
>
>--linas


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list