[PATCH] RTAS syscall - review request

Olof Johansson olof at austin.ibm.com
Thu Nov 13 03:31:10 EST 2003


Nathan Lynch wrote:

> static ssize_t ppc_rtas_rmo_buf_read(struct file *file, char __user
> *buf, size_t count, loff_t *ppos)
> {
>     int n;
>     char *kbuf = kmalloc(count, GFP_KERNEL);
>
>     n = sprintf(buf, "%p %x\n", rtas_rmo_buf, RTAS_SYSCALL_MAX);

                   ^^^ kbuf, right?

>     ...
>     copy_to_user(buf, kbuf, count);
>     kfree(kbuf);
> }

--
Olof Johansson                                        Office: 4E002/905
pSeries Linux Development                             IBM Systems Group
Email: olof at austin.ibm.com                          Phone: 512-838-9858
All opinions are my own and not those of IBM


** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list