[PATCH] EEH detection in acenic watchdog

Paul Mackerras paulus at samba.org
Fri Aug 29 09:19:48 EST 2003


Olof Johansson writes:

> Attached patch adds a call to eeh_check_failure in the watchdog function. This is an expensive call,
> but watchdog timeouts shouldn't happen (often) on a healthy system.

This is OK for our local ppc64 trees, but it's a bit ugly.  It's an
extra ifdef and it is putting something very pSeries-specific into a
driver that otherwise is platform-agnostic.

Maybe what we should propose is to add a "platform_error_check()"
function which can be called in these kinds of circumstances, with
null definitions on most architectures.

BTW, I think Jes Sorensen did the acenic driver in the context of his
work for a previous employer.  I don't know if he has any interest
in the acenic now (or even any acenic hardware to work on).

Paul.

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc64-dev mailing list