Async DMA question regarding dma_async_memcpy_buf_to_buf
Bruce_Leonard at selinc.com
Bruce_Leonard at selinc.com
Tue Nov 25 05:55:16 EST 2008
I have a question about
.../drivers/dma/dmaengine.c/dma_async_memcpy_buf_to_buf() in 2.6.28-rc2.
It looks like it always assumes that the source pointer points to data
coming from the CPU and the destination pointer always points to the DMA
device. I say this because of the following two lines from the function:
dma_src = dma_map_single(dev->dev, src, len, DMA_TO_DEVICE);
dma_dest = dma_map_single(dev->dev, dest, len, DMA_FROM_DEVICE);
As you can see 'src' is mapped DMA_TO_DEVICE indicating the data is going
from the CPU to the device, and 'dest' is mapped DMA_FROM_DEVICE,
indicating the opposite direction. Seems to me this means the function is
assuming a certain direction (i.e., a write to the device), but there
isn't a corresponding function for going the other direction. This leads
me to believe that the function is intended to operate in either
direction. But this is in contradiction to both the mapped directions and
what I've read in LDD3, ch 15.
The hardware doesn't care (I'm using an MPC8347E), as far as the DMA
engine is concerned these are just addresses. All of this goes to cache
coherency. The map/unmap functions are supposed to ensure that data is
copied and caches flushed at the right times to ensure cache coherency. So
the question is this; is the dma_async_memcpy_buf_to_buf() function
intended to be bi-directional and is it safe to pass it a 'src' pointer
that's actually coming from the device, or does there need to be a second
function for doing a copy from the device to the CPU?
Thanks.
Bruce
More information about the Linuxppc-embedded
mailing list