[PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

Segher Boessenkool segher at kernel.crashing.org
Thu Jul 17 13:19:44 EST 2008


>> Shouldn't it be enough to have a common compatible value in each
>> of these boards, e.g. "amcc,generic-ppc44x" and then just ignore the
>> specific type unless you need to do something special?
>
> This is bad for the same reason that "amcc,44x-<blah>" compatible 
> values
> are bad in device nodes.  The definition of '*-44x-*' changes over 
> time as
> new parts are added.  Compatible values should always reflect an exact
> part number.

Erm, no.

"compatible" entries should always contain the real part name to reduce
the chance that separate parties come up with the same "compatible"
name for two different devices.

Other than that, the name really doesn't matter, it's just _some_
string that uniquely identifies a device; and the device bindings will
document what is what.

Of course, if no binding is written, it becomes a lot more important
that names have a sane value ;-)


Segher



More information about the Linuxppc-embedded mailing list