[PATCH] PPC440EPx/440GRx EMAC support.

[Valentine Barshak]

Eugene Surovegin wrote:
> On Wed, Mar 21, 2007 at 11:04:38AM -0500, Olof Johansson wrote:
>   
>> On Tue, Mar 20, 2007 at 10:29:12PM +0300, Valentine Barshak wrote:
>>     
>>> diff -ruN linux.orig/drivers/net/ibm_emac/ibm_emac.h linux/drivers/net/ibm_emac/ibm_emac.h
>>> --- linux.orig/drivers/net/ibm_emac/ibm_emac.h	2007-03-16 18:03:51.000000000 +0300
>>> +++ linux/drivers/net/ibm_emac/ibm_emac.h	2007-03-18 18:53:08.000000000 +0300
>>> @@ -26,7 +26,7 @@
>>>  #if !defined(CONFIG_405GP) && !defined(CONFIG_405GPR) && !defined(CONFIG_405EP) && \
>>>      !defined(CONFIG_440GP) && !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && \
>>>      !defined(CONFIG_440EP) && !defined(CONFIG_NP405H) && !defined(CONFIG_440SPE) && \
>>> -    !defined(CONFIG_440GR)
>>> +    !defined(CONFIG_440GR) && !defined(CONFIG_440EPX) && !defined(CONFIG_440GRX)
>>>       
>> Same here. I know you only added a couple more, but it's reached critical
>> mass (well, it did a while ago).
>>     
>
> No, it's not same here. Please, take a time and look at the full code 
> this particular snippet has nothing to do with Konfig stuff.
>
> One can argue that it can be removed altogether, but I added this ugly 
> check for a reason - people were adding support for new 4xx SoCs 
> blindly in the past without checking that EMAC registers weren't 
> changed slightly.
>
> So, Valentine, keep this particular ugly ifdef as it is.
>
> Also, Valentine, next time CC me with any EMAC changes because I'm not 
> actively reading PPC maillists these days.
>
>   
Please, take a look at the updated 440EPx EMAC patch.
I've added IBM_EMAC_CLK_SEL option which is selected if both 
IBM_EMAC_PHY_RX_CLK_FIX is set and the processor is not 440GX.
The other "ugly" ifdef is left unchanged.
Thanks.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ppc440epx_emac_v1.patch
Url: http://ozlabs.org/pipermail/linuxppc-embedded/attachments/20070321/6a208f20/attachment.txt