[PATCH] PPC440EPx/440GRx Sequoia/Rainier board support.

Wolfgang Denk wd at denx.de
Thu Mar 22 02:43:17 EST 2007


Valentine,

in message <4601461E.9010006 at ru.mvista.com> you wrote:
>
> Add AMCC PPC440EPx/440GRx Sequoia/Rainier board support.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Signed-off-by: Valentine Barshak <vbarshak at ru.mvista.com>

Umm...

> --- linux.orig/arch/ppc/platforms/4xx/ppc440epx.c	1970-01-01 03:00:00.000000000 +0300
> +++ linux/arch/ppc/platforms/4xx/ppc440epx.c	2007-03-20 14:43:37.000000000 +0300
> @@ -0,0 +1,284 @@
> +/*
> + * arch/ppc/platforms/4xx/ppc440epx.c
> + *
> + * PPC440EPx I/O descriptions
> + *
> + * Wade Farnsworth <wfarnsworth at mvista.com>
> + * Copyright 2004-2007 MontaVista Software Inc.
> + * Copyright 2006 AMCC

The same file in our repository looks like this:

/*
 * arch/ppc/platforms/4xx/ppc440epx.c
 *
 * PPC440EPx I/O descriptions
 *
 * Copyright 2007 DENX Software Engineering, Stefan Roese <sr at denx.de>
 *
 * Wade Farnsworth <wfarnsworth at mvista.com>
 * Copyright 2004 MontaVista Software Inc.
 * Copyright 2006 AMCC


In other words: You *removed* Stefan Roese's (resp.  DENX)  Copyright
entry, and replaced it by one for MV?


I think this was not done by accident.

I don't know what to say.


I think your patches should be rejected.


Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you own a machine, you are in turn owned by it,  and  spend  your
time serving it..."    - Marion Zimmer Bradley, _The Forbidden Tower_



More information about the Linuxppc-embedded mailing list