[PATCH] # ppc: ppc4xx_set_src/dst_addr were only correct for DMA0

Roger Larsson roger.larsson at norran.net
Sun Jan 21 00:21:19 EST 2007


On Saturday 20 January 2007 00:02, Niklaus Giger wrote:
> DCRN_DMASAH0 + dmanr*2
to
> DCRN_DMASAH0 + dmanr * 0x8

Wouln't it be possible to give DCRN_DMASAH0 such an type that
DCRN_DMASAH0 + dmanr
would do? Or even better
DCRN_DMASAH[dmanr]

BTW this code looks suspicious, how will the 64BIT dma
ever work? Only highest 32 bits are stored...

PPC should really try to move toward the generic interface...

/RogerL



More information about the Linuxppc-embedded mailing list