[PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate
Ahmed S. Darwish
darwish.07 at gmail.com
Tue Feb 6 20:12:07 EST 2007
On Mon, Feb 05, 2007 at 11:22:06PM +0300, Alexey Dobriyan wrote:
> On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote:
> > A patch to use ARRAY_SIZE macro already defined in kernel.h.
>
> OK, but checks you're changing are strange. idx there is signed so
>
> BUG_ON(idx < 0 || idx > ARRAY_SIZE());
>
> should be more appropriate.
It's just a janitor patch. I don't like to mess with code logic in such
kind of patches (to minimize errors and because I can't find time to
understand all affected files since they are scattered allover the tree).
Thanks,
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
More information about the Linuxppc-embedded
mailing list