[PATCH] General CHRP/MPC5K2 platform support patch

Nicolas DET nd at bplan-gmbh.de
Sat Oct 28 00:52:27 EST 2006


Benjamin Herrenschmidt wrote:
> On Thu, 2006-10-26 at 14:00 -0600, Grant Likely wrote:
>> My comments are satisfied
>>
>> Acked-by: Grant Likely <grant.likely at secretlab.ca>
> 
> Nack.
> 
> The irq code doesn't properly use the genirq infrastructure. It's not
> setting flow handlers, not implementing set_irq_type, not using the new
> mask/unmask instead of the toplevel enable/disable...
> 
>

Done.

We agree on IRC last night to postpone this implementation later on. 
However, here it is.

This patch compiles fine when applied to the kernel 2.6.19-rc3. I also 
tested gcc 3.3.5 and 4.1.2.

I made some tests and did not found any issue. However, more 
testing/stressing/torturing and also with on others platforms is 
required to fully validate the driver.

Regards
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: chrpmpc52xx_2.6.19-rc3.patch
Url: http://ozlabs.org/pipermail/linuxppc-embedded/attachments/20061027/b21192fe/attachment.txt 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nd.vcf
Type: text/x-vcard
Size: 249 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc-embedded/attachments/20061027/b21192fe/attachment.vcf 


More information about the Linuxppc-embedded mailing list