[PATCH] CPM_UART: Fix non-console initialisation

Kalle Pokki kalle.pokki at iki.fi
Fri Oct 20 05:40:27 EST 2006


On 10/19/06, Vitaly Bordug <vbordug at ru.mvista.com> wrote:
> And we end up with init_portdesc called unconditionally? this would likely break, or at least confuse the
> code, that uses platform dev to pass resources offsets.

Well now that I look at it again, we should probably do

if (cpm_uart_no == 0)
     cpm_uart_init_portdesc();

to make it at least a little less confusing. Remember that
init_portdesc() is not called when using platform device, so this
should not affect those targets using it at all.

> Personally, I don't care much of compat stuff, unless it is breaking/confusing targets
> using proper resources...

I'm sure there are still lots of people using the compat mode. As long
as we have it, it should be kept functional.



More information about the Linuxppc-embedded mailing list