[PATCH] CPM_UART: Fix non-console initialisation (v2)

Kalle Pokki kalle.pokki at iki.fi
Sun Nov 12 01:15:19 EST 2006


On 11/11/06, Paul Mackerras <paulus at samba.org> wrote:
> Kalle Pokki writes:
>
> > Hmm, it seems you already pushed the changes. This should apply to the
> > current 'merge' branch.
>
> That on its own is hard to justify as a bug fix, isn't it?

Sure, but since you removed the last hunk of the patch that became
0091cf5a6ae6e52fc95ceb53200975ef2c81c206, we now have a little
inconsistent definitions:

in cpm_uart.h
int __init cpm_uart_init_portdesc(void);

in cpm_uart_cpm1.c
int __init cpm_uart_init_portdesc(void)
{
}

in cpm_uart_cpm2.c
int cpm_uart_init_portdesc(void)
{
}



More information about the Linuxppc-embedded mailing list