[PATCH] adding ROM chips to device tree: respin

Vitaly Wool vwool at ru.mvista.com
Wed Nov 8 08:17:01 EST 2006


> > +     - memory_space : Offset and length of the register set for the device.
> 
>     NAK. There's no need to define an extra property where "reg" should be used.

The register set is actually not there and depends on flash chip type.
So using regs here is misleading.

> > +
> > +	/*
> > +	 * We care only about physmap devices now as there's no
> > +	 * description defined for other ROM types yet
> > +	 */
> 
>     Not true. The description only says that it's *most probably* compatible 
> with "physmap", that's all. I don't see why we have to limit ourselves here.

Effectively we care about NOR chips and similar which are
memory-mapped. 

Vitaly




More information about the Linuxppc-embedded mailing list