[PATCH/RFC] powerpc: Add of_platform support for OHCI/Bigendian HC

[Nicolas DET]

Benjamin Herrenschmidt wrote:
> On Thu, 2006-11-02 at 09:23 +1100, Benjamin Herrenschmidt wrote:
> 
> And in english here too....
> 
>> On Wed, 2006-11-01 at 21:31 +0100, Nicolas DET wrote:
>>
>>> +/**+	ohci = hcd_to_ohci(hcd);
>>> +	ohci->flags |= OHCI_BIG_ENDIAN;
>>> +	ohci_hcd_init(ohci);
>> Bon, c'est pas mal. Le seul truc ici, c'est que je prefererais que
>> big-endian ne soit pas hard-code comme ca mais depende du device-tree.
>> Ce code doit pouvoir etre re-utilise pour des implementations
>> little-endian.
> 
> Ok, so it looks good. The only thing here is that I would prefer if the
> big-endian setting wasn't hard-coded, but set based on the device-tree,
> so that this code can be re-used for little-endian implementations.
> 
>>> +	retval = usb_add_hcd(hcd, irq, IRQF_DISABLED);
>>> +	if (retval == 0)
>>> +		return retval;
>> Pourquoi IRQF_DISABLED ?
> 
> Why IRQF_DISABLED ?
> 

It's like this in ofsoc-ppc. As I am not sure what it does exactly I 
left it like this. This module performs well here so far.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: archpowerpc_ohciof.patch
Url: http://ozlabs.org/pipermail/linuxppc-embedded/attachments/20061102/83adcee4/attachment.txt 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nd.vcf
Type: text/x-vcard
Size: 249 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc-embedded/attachments/20061102/83adcee4/attachment.vcf