[PATCH] [POWERPC] Remove unneeded memset from mpc52xx_psc_uart probe function

Grant Likely grant.likely at secretlab.ca
Wed Nov 1 19:39:55 EST 2006


This allows the console to continue to work after initializing the port
for full serial access.  However, this is not a proper fix.  The init
behaviour between console and serial driver access must be reengineered

Signed-off-by: Grant Likely <grant.likely at secretlab.ca>
---
 drivers/serial/mpc52xx_uart.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c
index 09bf8e0..f194010 100644
--- a/drivers/serial/mpc52xx_uart.c
+++ b/drivers/serial/mpc52xx_uart.c
@@ -753,7 +753,6 @@ mpc52xx_uart_probe(struct of_device *op,
 	struct resource res;
 	int ret;
 
-	printk("Got here!\n");
 	dev_dbg(&op->dev, "mpc52xx_uart_probe(op=%p, match=%p)\n", op, match);
 
 	/* Check validity & presence */
@@ -763,8 +762,6 @@ mpc52xx_uart_probe(struct of_device *op,
 	/* Init the port structure */
 	port = &mpc52xx_uart_ports[idx];
 
-	memset(port, 0x00, sizeof(struct uart_port));
-
 	spin_lock_init(&port->lock);
 	port->fifosize	= 512;
 	port->iotype	= UPIO_MEM;
-- 
1.4.3.rc2.g0503




More information about the Linuxppc-embedded mailing list