set_multicast_list() commented out in fcc_enet.c

[Benjamin Dapon-Pigatto]

Hi Alex,

I had the same problem few months ago with arch/ppc/cpm2_io/fcc_enet.c. 
It should be the same driver.
I suppose that multicast is not correctly implemented. I have commented this
return and promiscuous mode works fine but I have never tried with
multicast.

Benjamin

-----Message d'origine-----
De : linuxppc-embedded-bounces at ozlabs.org
[mailto:linuxppc-embedded-bounces at ozlabs.org] De la part de Alex Zeffertt
Envoyé : mardi 31 mai 2005 11:23
À : linuxppc-embedded at ozlabs.org
Objet : set_multicast_list() commented out in fcc_enet.c

Hi all,

I've noticed that in arch/ppc/8260_io/fcc_enet.c at the very top of the
function set_multicast_list() there is a return statement - effectively
commenting out the rest of the code.  There is no comment saying why it
is there.

An effect of this is that you cannot put the device in promiscuous mode,
which is required when adding it to a bridge.

Please can anyone say why this "return;" is there?

Thanks,

Alex

PS I'm using denx's linuxppc_devel tagged 2005-03-06, which is based
on linux-2.4.25.
_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded at ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded