[PATCH] BOOKE_WDT Part 1/2 (Re: PPC 44x Watchdog timer)

Kumar Gala kumar.gala at freescale.com
Wed May 18 03:00:04 EST 2005


On May 17, 2005, at 9:47 AM, Takeharu KATO wrote:

> Hi Kumar:
>
> >> No problem, can you replace all the cmd line parsing with
> >> early_param() code in arch/ppc/kernel/setup.c.  Take a look at
> >> arch/ppc64/kernel/setup.c for an example.  We still need to add a 
> call
> >> to parse_early_param() in setup_arch().
>  >>
>  > Sorry, I can not figure out what you want.
> > As far as I look the source tree,arch/ppc/kernel/setup.c does not 
> have
>  > the function called early_param.
>  > Would you give me a more precise explanation?
>  >
> On second thought, I make sense what you said.
> You asked me that I make some kind of cleanups, didn't you?
>  If it is true, I'll try to clean up these setups, but it may be
>  take the time.

Yes, I think with these changes to us early_param() for command line 
parsing in a single place will make the first patch look good.

I'm still not sure what suggestions I have for the second patch, I was 
more just letting you know my thinking about the fact that it concerned 
me that the exception handler code was not in arch/ppc/kernel.  Not to 
say this is wrong, it just doesn't feel write.

- kumar




More information about the Linuxppc-embedded mailing list