[PATCH] BOOKE_WDT Part 1/2 (Re: PPC 44x Watchdog timer)

[Kumar Gala]

No problem, can you replace all the cmd line parsing with early_param() 
code in arch/ppc/kernel/setup.c.  Take a look at 
arch/ppc64/kernel/setup.c for an example.  We still need to add a call 
to parse_early_param() in setup_arch().

Matt & I need to talk about the driver patch.  Once I have more 
feedback on that I'll let you know.  The major issue I have is having 
the interrupt handler in drivers/char/watchdog/.. instead of 
arch/ppc/kernel/traps.c.  However, I dont have a good idea how to 
structure the changes.

- kumar

On May 16, 2005, at 1:57 AM, Takeharu KATO wrote:

> Hi Kumar:
>
> I'm sorry that the reply becomes slow.
>
> Kumar Gala wrote:
>  >>
>  >
> > Any reason you moved this code into DecrementerHandler?
> >
> >>   /* 0x1000 - Programmable Interval Timer (PIT) Exception */
>  >>          START_EXCEPTION(0x1000, Decrementer)
>  >>  -       NORMAL_EXCEPTION_PROLOG
> >> -       lis     r0,TSR_PIS at h
> >> -       mtspr   SPRN_TSR,r0             /* Clear the PIT exception 
> */
>  >>  -       addi    r3,r1,STACK_FRAME_OVERHEAD
> >> -       EXC_XFER_LITE(0x1000, timer_interrupt)
> >> +       b    DecrementerHandler
> >>
>  Current PIT exception handler is too big.
>  If it is not moved, compilation is failed with relocation error.
>  Because current PIT handler overwrites WDT handler's codes, the 
> compiler
> can not relocate PIT and WDT handler correctly.