[PATCH] CPM2 cleanups
Kumar Gala
kumar.gala at freescale.com
Wed Mar 23 16:46:22 EST 2005
Jason, why did you bother to implement these functions, they dont
provide any value for us?
It looks like startup() & shutdown() are only used in IRQ probing code
or code in which enable/disable will be used instead.
- kumar
On Mar 22, 2005, at 3:18 PM, Wolfgang Denk wrote:
> In message <1111523269.2987.58.camel at ad.doubleclick.net> you wrote:
> >
> ...
> > +static unsigned int cpm2_startup_irq(unsigned int irq)
> > +{
> > + cpm2_unmask_irq(irq);
> > + return 0;
> > +}
> > +
> > +static void cpm2_shutdown_irq(unsigned int irq)
> > +{
> > + cpm2_mask_irq(irq);
> > +}
>
> Why is cpm2_startup_irq() not void like cpm2_shutdown_irq() ?
>
> Best regards,
>
> Wolfgang Denk
>
> --
> Software Engineering: Embedded and Realtime Systems, Embedded Linux
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Overflow on /dev/null, please empty the bit bucket.
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
More information about the Linuxppc-embedded
mailing list