[PATCH 3/3] PPC440EP IBM EMAC support

Eugene Surovegin ebs at ebshome.net
Wed Mar 16 06:22:16 EST 2005


On Tue, Mar 15, 2005 at 11:58:54AM -0700, Wade Farnsworth wrote:
> This patch adds support to the IBM EMAC ethernet driver for the 440EP.
> 
> Regards,
> Wade Farnsworth
> 
> Signed-off-by: Wade Farnsworth <wfarnsworth at mvista.com>
> 

> --- linux-2.6.11-bk7/drivers/net/ibm_emac/ibm_emac_phy.c	2005-03-02 00:38:13.000000000 -0700
> +++ linux-2.6.11-bk7-440ep/drivers/net/ibm_emac/ibm_emac_phy.c	2005-03-11 16:32:01.000000000 -0700
> @@ -27,6 +27,12 @@
>  
>  #include "ibm_emac_phy.h"
>  
> +#ifdef CONFIG_BAMBOO
> +#define BAMBOO_REV0 (mfspr(PVR) == PVR_440EP_RA)
> +#else
> +#define BAMBOO_REV0 0
> +#endif
> +

I really don't like it. Chip revision doesn't imply which board 
this code is running on. Please, think of some other way to do this or 
drop this completely.

--
Eugene



More information about the Linuxppc-embedded mailing list