RFC: cpm2_devices.c
Kumar Gala
kumar.gala at freescale.com
Fri Jun 17 01:02:03 EST 2005
I'm not sure I follow on what you want done. I done see the
pq2_device.c file changing much once we put it in place. If there is a
little duplication between pq1_device.c, pq2_device.c and
mpc85xx_device.c I'm not to concerned about it since the only
information in there is memory offsets and IRQs.
If the structures for an SCC uart driver are the same for PQ1 and PQ2
then I would expect the SCC uart driver to handle that fact going
forward.
- kumar
On Jun 16, 2005, at 1:42 AM, Pantelis Antoniou wrote:
> Let me hop in here...
>
> Have you thought about breaking up the structures per
> cpm peripheral?
>
> Some registers are unique for each processor family, but
> others are (almost) common to all.
>
> For example SCC parameters & stuff are the same on 8xx/82xx ...
>
> IMHO keeping one definition in the tree for these will make
> keeping them in sync easier.
>
> Then the main header file will be the definitions of the
> unique registers, a number of defines for the structures offsets
> and a list of included files for the common peripherals...
>
> Regards
>
> Pantelis
More information about the Linuxppc-embedded
mailing list