[PATCH] ppc32: Adds MPC885ADS, MPC866ADS and MPC8272ADS-specific platform stuff for fs_enet

Kumar Gala galak at kernel.crashing.org
Fri Dec 9 03:14:07 EST 2005


On Dec 8, 2005, at 7:40 AM, Vitaly Bordug wrote:

> Matt,
> Matthew McClintock wrote:
>> On Mon, 2005-11-28 at 10:00 -0700, Vitaly Bordug wrote:
>>> +       mpc82xx_fcc1_pdata.dpram_offset =
>>> mpc82xx_fcc2_pdata.dpram_offset = (u32)cpm2_immr->im_dprambase;
>>> +       mpc82xx_fcc1_pdata.fcc_regs_c =  
>>> mpc82xx_fcc2_pdata.fcc_regs_c
>>> = (u32)cpm2_immr->im_fcc_c;
>> I'm not sure if this has already been discussed, but what is  
>> stopping us
>> from including this in the platform definition files along with the
>> other offsets?
> IIRC, because these values could vary along the PQ2 family, when  
> all the stuff in pq2_devices.c should be static and applicable to  
> any PQ2 which does have the corresponding device.

How much variation is there?  I'm not sure how or why it would be  
different from how we handle the FEC and TSEC on 8540.

- kumar



More information about the Linuxppc-embedded mailing list