[PATCH] Support 8xx based Silicon Turnkey XTc

[Wolfgang Denk]

Dear Pantelis,

in message <200512052115.45858.pantelis.antoniou at gmail.com> you wrote:
> Support of Silicon Turnkey's XTc.

Ummm .. a few questions...

>  arch/ppc/platforms/stxxtc.h       |  285 +++++++++++++

Here you include a lot of inlined code, but I have  problems  finding
out  what  it  is  good  for.  For  example,  there  is  a full-blown
bit-banging SPI driver included which is nowhere referenced.

Am I missing something, or should this be cleaned up a bit?

>  drivers/mtd/maps/stxxtc_nor.c     |  326 +++++++++++++++

I think it is not a good idea to embed spaces in the flash map names,
as this will make it impossible  to  select  such  devices  from  the
kernel  command  line  which  you  seem  to intend (at least you have
CONFIG_MTD_CMDLINE_PARTS enabled in your default configuration) ?


And a design question: Why are  you  using  the  concatenating  (NOR)
flash  driver?  Why don't you simply map the flashes (in U-Boot) such
that you have one contiguous region? That would  make  flash  use  in
U-Boot much more convenient, too.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where would we be without rhetorical questions?