[PATCH] 8xx: add cpm_get_cpmp()

Aristeu Sergio Rozanski Filho aris at cathedrallabs.org
Sun Aug 7 09:42:44 EST 2005


> It already is exported, declared as
> 
> commproc.h:extern       cpm8xx_t        *cpmp;          /* Pointer to comm processor */
> 
> 
> and many drivers use the pointer directly.
> 
> arch/ppc/8260_io/ drivers also use the same convention.
> 
> Not sure I see much advantage in changing it?
but not with EXPORT_SYMBOL(). I noticed this while compiling i2c stuff
as module. also, I think it's better add a function to do this instead
doing EXPORT_SYMBOL() in a variable.
what you think?

-- 
Aristeu




More information about the Linuxppc-embedded mailing list