[PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to the stock linux-2.5 (updated)

Kumar Gala kumar.gala at freescale.com
Fri Apr 22 00:00:20 EST 2005

On Apr 21, 2005, at 7:04 AM, Vitaly Bordug wrote:

> Kumar Gala wrote:
> >On Wed, 13 Apr 2005, Vitaly Bordug wrote:
>  >
>  >Finally, had some time to really look at this patch, comments are 
> inline.
> >Look for (galak).  A few high level comments:
>  >
>  >Can we fold pq2ads_setup_hose into pq2ads_setup_pci?
>  >
>  No problem, I think...


> > Also, is there
>  >anything to be done to unify m8260_setup_pci &
> >pq2ads_setup_pci..
> >
>  Well, in my opinion, m8260_setup_pci should be replaced with
> pq2ads_setup_pci, as far as they are intended to do the same (as I
> mentioned in my very first PCI patch marked as RFC). But I actually
> cannot test this stuff on anything other than 8272ads, so this way I'm
>  trying not to break existing code. The latter, BTW, currently has
> limited functionality and I _guess_ I will not break anything if only
> pq2ads_setup_pci remain. What do you think?

Not 100% sure.  Maybe Wolfgang or someone else know what the existing 
m8260 pci functionality is suppose to work with.  It seems odd that it 
did not have some of the bits you added for the 8272ads.  Its not clear 
to me if it actually worked on any systems or not.  Let see if Wolfgang 
has any insight as a first step.

> Other issues will be fixed shortly.


- kumar

More information about the Linuxppc-embedded mailing list