next pass of cleaning up micropatch.c

Wolfgang Denk wd at
Sat Oct 9 09:29:15 EST 2004

In message <Pine.LNX.4.60.0410081908410.3331 at localhost.localdomain> you wrote:
> >> nice idea, but sadly, doomed to failure.  note that the code to copy
> >> the patch arrays *requires* you to be able to take the sizeof() those
> > This is not right. Guess how memcpy() works - it's a function, btw.
> sure.  and it accepts a size parameter, which is why it works.  i'm 
> not sure what you're getting at.

I'm getting at your "doomed to failure" argument.

I'm surprised that you didn't think about the possibility to pass the
patch length as an argument to the function, that's all.  This  seems
all  too  obvious  to  me.  (If  you like you can this make an inline
function - then the code will be more or less identical  to  what  we
have now [which does not make the code a bit better, btw.])

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at
The only person who always got his work done by Friday
                                                 was Robinson Crusoe.

More information about the Linuxppc-embedded mailing list