next pass of cleaning up micropatch.c

Dan Malek dan at embeddededge.com
Sat Oct 9 01:34:06 EST 2004


On Oct 8, 2004, at 8:44 AM, Robert P. J. Day wrote:
> + *  Shortcut macros for patching code.
>   */
> +
> +#define PATCH2000 \
> +	dp = (uint *)(commproc->cp_dpmem); \
> +	for (i=0; i<(sizeof(patch_2000)/4); i++) \
> +		*dp++ = patch_2000[i];
> +
> +#define PATCH2E00 \
> +	dp = (uint *)&(commproc->cp_dpmem[0x0e00]); \
> +	for (i=0; i<(sizeof(patch_2e00)/4); i++) \
> +		*dp++ = patch_2e00[i];
> +
> +#define PATCH2F00 \
> +	dp = (uint *)&(commproc->cp_dpmem[0x0f00]); \
> +	for (i=0; i<(sizeof(patch_2f00)/4); i++) \
> +		*dp++ = patch_2f00[i];

Please get rid of these macros and place the code where it
belongs.  They add no value and just make it harder to
read the code and understand what it does.

Thanks.


	-- Dan




More information about the Linuxppc-embedded mailing list