[PATCH][PPC32] Performance Monitor/Oprofile support for e500

[Andrew Morton]

Kumar Gala <galak at linen.sps.mot.com> wrote:
>
> Andrew,
> 
> Adds oprofile support for the e500 PowerPC core.

- arch/ppc/kernel/perfmon_fsl_booke.c has prototypes for init_pmc_stop()
  and friends, but those prototypes are already in
  include/asm-ppc/perfmon.h

- please don't put prototypes and extern declarations in .c files.  Ever.
  It defeats typechecking.  Put them in a header file which is visible to
  all callers/users as well as to the implementation.

- Do these need to be exported to modules?

	+EXPORT_SYMBOL(init_pmc_stop);
	+EXPORT_SYMBOL(set_pmc_event);
	+EXPORT_SYMBOL(set_pmc_user_kernel);
	+EXPORT_SYMBOL(set_pmc_marked);
	+EXPORT_SYMBOL(pmc_start_ctr);
	+EXPORT_SYMBOL(pmc_start_ctrs);
	+EXPORT_SYMBOL(pmc_stop_ctrs);
	+EXPORT_SYMBOL(dump_pmcs);

  and if so, does an EXPORT_SYMBOL_GPL() not suffice?

- This:

	+extern void (*perf_irq)(struct pt_regs *);

  should be in a header file.



I'll queue the patch up.  Fixups relative to this patch would be
appreciated, thanks.