PATCH: arch/ppc/8xx_io_fec.c

Tom Rini trini at kernel.crashing.org
Wed May 28 06:13:43 EST 2003


On Tue, May 27, 2003 at 03:33:52PM -0400, Dan Malek wrote:

> Tom Rini wrote:
>
> >Dan, do you see any problems with this?
>
> Yes.  There are silicon revisions that require the FEC to
> be enabled for the MDIO to operate.  I don't remember if it was
> listed in errata or in some of the early supplements.  This code
> change may work in this particular case, but I know it's required
> for some parts.  I have not looked at the detail of the patch
> and the code it moves to see if this is done elsewhere.

How would you suggest working around both this problem, and the problems
that Jean-Denis reported?  Having either be broken for the sake of the
other can't be acceptiable, can it? :)

> The code formatting looks like crap, so that needs to be fixed.

That's trivial 'tho. :)

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-embedded mailing list