[PATCH] 8xx_io/uart.c

Paul Mackerras paulus at samba.org
Wed Feb 12 10:54:02 EST 2003


Joakim Tjernlund writes:

> I think I know why the are as they are now. KGDB/XMON stuff is messy and if you
> are sure that XMON/KGDB never outputs a LF all is fine.

Well I can tell you for a fact that xmon will output \n.

Dan, the code looks fragile as it is - why shouldn't the second part
(inside the if (*s == 10) body) do the same test as the first part?
Relying on xmon/kgdb never outputting \n sounds like a bad idea to me.

Paul.

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-embedded mailing list