[PATCH 2.5] More i8259 cleanups

Dan Malek dan at embeddededge.com
Thu May 16 06:43:57 EST 2002


Tom Rini wrote:

> Hey all.  I've been doing more OpenPIC/i8259 work and here's the next
> patch I'll be pushing to linuxppc-2.5 soon.

Looks good.....just one little thing, how about we wrap some more of these
functions with __init attributes?  There are a bunch of these couple of
line functions, like openpic_enable_sie(), that are only called from the
init function.  That's one of the reasons I originally surrounded them
by ifdefs......probably doesn't amount to much, but it is at least logically
consistent since the function(s) that call them are also __init's :-)

Thanks.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-embedded mailing list