status of linuxppc_2_4_devel for ppc405gp
Dan Malek
dan at mvista.com
Fri Aug 24 15:06:26 EST 2001
David Gibson wrote:
to break.
>
> Ah yes, I ran into that one when I started converting the ppc405_enet
> driver to use ioremap() and in_beXX() instead of the godawful mess of
> direct access and explicit eieio()s it uses now.
Umm....what are you doing? Those registers are already mapped via
ioremap(), so that isn't necessary. What you consider a "godawful mess"
is a personal preference, and I prefer the programming style that
currently exists. I don't have any love for the driver, but it
certainly isn't a patch I would check in.......
The only modification that _should_ be done is moving the generic
on-board I/O mapping done during board initialization to be a specific
ioremap() in the driver, and actually looking at the eieio() to ensure
they are really necessary.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
More information about the Linuxppc-embedded
mailing list