cpm_enet_down and MAC address change.

Graham Stoney greyham at research.canon.com.au
Mon Sep 4 12:03:45 EST 2000


Daris A Nevil writes:
> I have been promising myself that I would re-work the ethernet driver ...

If you do, I think it would be good to integrate similar changes to those I
made to the FEC driver, in the patch at:
    http://members.xoom.com/greyhams/linux/patches/2.2/fecdmaskb.patch

In particular, DMA directly into the skbuf avoids a copy, and received
packets that get dropped should only be counted in rx_dropped -- not counted
again in rx_packets.  Also, it's good to avoid reading the buffer descriptor
status bits multiple times, especially since they're uncached.

Regards,
Graham
--
Graham Stoney
Principal Hardware/Software Engineer
Canon Information Systems Research Australia
Ph: +61 2 9805 2909  Fax: +61 2 9805 2929

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-embedded mailing list