[PATCH] ASoC: update outdated comments for removed snd_soc_new_pcms()
Kexin Sun
kexinsun at smail.nju.edu.cn
Sat Mar 21 21:56:52 AEDT 2026
The function snd_soc_new_pcms() was removed during the
multi-component refactoring in commit f0fba2ad1b6b ("ASoC:
multi-component - ASoC Multi-Component Support"). Its PCM creation
role is now handled by soc_new_pcm(), which was later moved to
sound/soc/soc-pcm.c by commit ddee627cf6bb ("ASoC: core - Separate
out PCM operations into new file.").
In fsl_dma.c, update the comment to reference soc_new_pcm() and the
pcm_construct callback. Also remove the stale paragraph about
snd_dma_alloc_pages() always allocating in lowmem, since commit
e159704f7920 ("ASoC: fsl_dma: Use managed buffer allocation")
replaced that call with snd_pcm_set_fixed_buffer_all().
In siu_pcm.c, remove the stale comment referencing
snd_soc_new_pcms() and the no-longer-existing socdev structure.
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun at smail.nju.edu.cn>
---
sound/soc/fsl/fsl_dma.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
index 26ddbe867b58..ec378e32ea71 100644
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/fsl/fsl_dma.c
@@ -267,15 +267,10 @@ static irqreturn_t fsl_dma_isr(int irq, void *dev_id)
/**
* fsl_dma_new: initialize this PCM driver.
*
- * This function is called when the codec driver calls snd_soc_new_pcms(),
- * once for each .dai_link in the machine driver's snd_soc_card
+ * This function is called by soc_new_pcm() via the pcm_construct
+ * callback, once for each DAI link in the machine driver's snd_soc_card
* structure.
*
- * snd_dma_alloc_pages() is just a front-end to dma_alloc_coherent(), which
- * (currently) always allocates the DMA buffer in lowmem, even if GFP_HIGHMEM
- * is specified. Therefore, any DMA buffers we allocate will always be in low
- * memory, but we support for 36-bit physical addresses anyway.
- *
* Regardless of where the memory is actually allocated, since the device can
* technically DMA to any 36-bit address, we do need to set the DMA mask to 36.
*/
--
2.25.1
More information about the Linuxppc-dev
mailing list