[PATCH v2 1/4] ASoC: dt-bindings: fsl,audmix: Add support for i.MX952 platform

Krzysztof Kozlowski krzk at kernel.org
Wed Jan 21 18:59:18 AEDT 2026


On Tue, Jan 20, 2026 at 07:07:48PM +0800, Shengjiu Wang wrote:
> On Tue, Jan 20, 2026 at 6:31 PM Krzysztof Kozlowski <krzk at kernel.org> wrote:
> >
> > On Tue, Jan 20, 2026 at 11:52:07AM +0800, Shengjiu Wang wrote:
> > > There is no power domain defined on i.MX952, so make power-domains to be
> >
> > There is no defined or there is no power domain? If the first, then this
> > patch is incomplete. Please read writing bindings part about complete
> > bindings. If the latter, then you miss constraints ":false" and commit
> > msg phrasing is incorrect (and remember that in such case you won't be
> > able to add power domains later because now you add complete binding).
> 
> Thanks for pointing this out.
> 
> There is a power domain on i.MX952 for the mix system of AUDMIX.
> But it is enabled by default,  AUDMIX device don't need to enable it.

This should be explained in the commit msg.

Best regards,
Krzysztof



More information about the Linuxppc-dev mailing list