[PATCH v2 10/11] cpufreq: s5pv210: Simplify with scoped for each OF child loop
Krzysztof Kozlowski
krzysztof.kozlowski at oss.qualcomm.com
Tue Jan 6 20:15:20 AEDT 2026
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler. Note that there is another part of code using "np"
variable, so scoped loop should not shadow it.
Acked-by: Viresh Kumar <viresh.kumar at linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>
---
Depends on the first patch.
---
drivers/cpufreq/s5pv210-cpufreq.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index ba8a1c96427a..e64e84e1ee79 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -629,19 +629,17 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
goto err_clock;
}
- for_each_compatible_node(np, NULL, "samsung,s5pv210-dmc") {
- id = of_alias_get_id(np, "dmc");
+ for_each_compatible_node_scoped(dmc, NULL, "samsung,s5pv210-dmc") {
+ id = of_alias_get_id(dmc, "dmc");
if (id < 0 || id >= ARRAY_SIZE(dmc_base)) {
- dev_err(dev, "failed to get alias of dmc node '%pOFn'\n", np);
- of_node_put(np);
+ dev_err(dev, "failed to get alias of dmc node '%pOFn'\n", dmc);
result = id;
goto err_clk_base;
}
- dmc_base[id] = of_iomap(np, 0);
+ dmc_base[id] = of_iomap(dmc, 0);
if (!dmc_base[id]) {
dev_err(dev, "failed to map dmc%d registers\n", id);
- of_node_put(np);
result = -EFAULT;
goto err_dmc;
}
--
2.51.0
More information about the Linuxppc-dev
mailing list