[PATCH v4 11/28] KVM: x86/mmu: Drop the return code from kvm_x86_ops.remove_external_spte()

Huang, Kai kai.huang at intel.com
Fri Oct 31 09:26:20 AEDT 2025


On Thu, 2025-10-30 at 13:09 -0700, Sean Christopherson wrote:
> Drop the return code from kvm_x86_ops.remove_external_spte(), a.k.a.
> tdx_sept_remove_private_spte(), as KVM simply does a KVM_BUG_ON() failure,
> and that KVM_BUG_ON() is redundant since all error paths in TDX also do a
> KVM_BUG_ON().
> 
> Opportunistically pass the spte instead of the pfn, as the API is clearly
> about removing an spte.
> 
> Suggested-by: Rick Edgecombe <rick.p.edgecombe at intel.com>
> Reviewed-by: Binbin Wu <binbin.wu at linux.intel.com>
> Signed-off-by: Sean Christopherson <seanjc at google.com>
> 

Reviewed-by: Kai Huang <kai.huang at intel.com>


More information about the Linuxppc-dev mailing list