[PATCH 4/4] powerpc/kdump: add support for high crashkernel reservation
Sourabh Jain
sourabhjain at linux.ibm.com
Tue Oct 28 02:13:38 AEDT 2025
With this changes included crashkernel=xxM,high will be supported on
powerpc. This allow user to allocated crashkernel memory on higer memory
region and keeping the low memory allocation minimal.
The low memory reservation is by default set to 64 MB and it is reserved
below RTAS_INSTANTIATE_MAX (1G) to make sure rtas instantiation work
properly.
powerpc uses generic crashkernel parser and reserve functions and they
are capable of handling high crashkernel reservtion so
arch_reserve_crashkernel() is updated call generic crashkernel praser
and reserve function with resptive options to make
crashkernel=XXM,high prase and make crashkernel memory get reserved on
higher memory regions.
Note: High crashkernel is supported only on PPC 64-bit systems when
64-bit RTAS is instantiated and Radix MMU is enabled; otherwise, the
crashkernel reservation falls back to the default, even if the kernel
command includes crashkernel=XXM,high.
Cc: Baoquan he <bhe at redhat.com>
Cc: Hari Bathini <hbathini at linux.ibm.com>
Cc: Madhavan Srinivasan <maddy at linux.ibm.com>
Cc: Mahesh Salgaonkar <mahesh at linux.ibm.com>
Cc: Michael Ellerman <mpe at ellerman.id.au>
Cc: Ritesh Harjani (IBM) <ritesh.list at gmail.com>
Cc: Shivang Upadhyay <shivangu at linux.ibm.com>
Signed-off-by: Sourabh Jain <sourabhjain at linux.ibm.com>
---
arch/powerpc/include/asm/crash_reserve.h | 8 +++++
arch/powerpc/include/asm/kexec.h | 1 +
arch/powerpc/include/asm/rtas.h | 9 +++++
arch/powerpc/kexec/core.c | 45 +++++++++++++++++-------
4 files changed, 51 insertions(+), 12 deletions(-)
diff --git a/arch/powerpc/include/asm/crash_reserve.h b/arch/powerpc/include/asm/crash_reserve.h
index 6467ce29b1fa..d96d7726104a 100644
--- a/arch/powerpc/include/asm/crash_reserve.h
+++ b/arch/powerpc/include/asm/crash_reserve.h
@@ -2,7 +2,15 @@
#ifndef _ASM_POWERPC_CRASH_RESERVE_H
#define _ASM_POWERPC_CRASH_RESERVE_H
+#include <asm/rtas.h>
+
/* crash kernel regions are Page size agliged */
#define CRASH_ALIGN PAGE_SIZE
+#define DEFAULT_CRASH_KERNEL_LOW_SIZE SZ_64M
+
+#define CRASH_ADDR_LOW_MAX RTAS_INSTANTIATE_MAX
+#define CRASH_ADDR_HIGH_MAX memblock_end_of_DRAM()
+
+
#endif /* _ASM_POWERPC_CRASH_RESERVE_H */
diff --git a/arch/powerpc/include/asm/kexec.h b/arch/powerpc/include/asm/kexec.h
index bd4a6c42a5f3..080fef2344b4 100644
--- a/arch/powerpc/include/asm/kexec.h
+++ b/arch/powerpc/include/asm/kexec.h
@@ -116,6 +116,7 @@ int setup_new_fdt_ppc64(const struct kimage *image, void *fdt, struct crash_mem
int __init overlaps_crashkernel(unsigned long start, unsigned long size);
extern void arch_reserve_crashkernel(void);
extern void kdump_cma_reserve(void);
+unsigned long long __init get_crash_base(unsigned long long crash_base);
#else
static inline void arch_reserve_crashkernel(void) {}
static inline int overlaps_crashkernel(unsigned long start, unsigned long size) { return 0; }
diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h
index aaa4c3bc1d61..d290437d8131 100644
--- a/arch/powerpc/include/asm/rtas.h
+++ b/arch/powerpc/include/asm/rtas.h
@@ -561,6 +561,14 @@ static inline int page_is_rtas_user_buf(unsigned long pfn)
return 0;
}
+static inline bool is_rtas_high_crashkernel_capable(void)
+{
+ if (rtas_64)
+ return true;
+
+ return false;
+}
+
/* Not the best place to put pSeries_coalesce_init, will be fixed when we
* move some of the rtas suspend-me stuff to pseries */
void pSeries_coalesce_init(void);
@@ -569,6 +577,7 @@ void rtas_initialize(void);
static inline int page_is_rtas_user_buf(unsigned long pfn) { return 0;}
static inline void pSeries_coalesce_init(void) { }
static inline void rtas_initialize(void) { }
+static inline bool is_rtas_high_crashkernel_capable(void) { return true; }
#endif
#ifdef CONFIG_HV_PERF_CTRS
diff --git a/arch/powerpc/kexec/core.c b/arch/powerpc/kexec/core.c
index 25744737eff5..09b7518bba36 100644
--- a/arch/powerpc/kexec/core.c
+++ b/arch/powerpc/kexec/core.c
@@ -15,6 +15,7 @@
#include <linux/irq.h>
#include <linux/ftrace.h>
+#include <asm/rtas.h>
#include <asm/kdump.h>
#include <asm/machdep.h>
#include <asm/pgalloc.h>
@@ -61,7 +62,7 @@ void machine_kexec(struct kimage *image)
#ifdef CONFIG_CRASH_RESERVE
-static unsigned long long __init get_crash_base(unsigned long long crash_base)
+unsigned long long __init get_crash_base(unsigned long long crash_base)
{
#ifndef CONFIG_NONSTATIC_KERNEL
@@ -101,35 +102,55 @@ static unsigned long long __init get_crash_base(unsigned long long crash_base)
#endif
}
+static bool high_crashkernel_supported(void)
+{
+#if defined(CONFIG_PPC64) && (defined(CONFIG_PPC_PSERIES) || defined(CONFIG_PPC_POWERNV))
+ if (early_radix_enabled() && is_rtas_high_crashkernel_capable())
+ return true;
+#endif
+ return false;
+}
+
void __init arch_reserve_crashkernel(void)
{
- unsigned long long crash_size, crash_base, crash_end;
+ unsigned long long crash_size, crash_base, crash_end, low_size = 0;
unsigned long long kernel_start, kernel_size;
unsigned long long total_mem_sz;
+ bool high = false;
int ret;
total_mem_sz = memory_limit ? memory_limit : memblock_phys_mem_size();
/* use common parsing */
ret = parse_crashkernel(boot_command_line, total_mem_sz, &crash_size,
- &crash_base, NULL, &cma_size, NULL);
+ &crash_base, &low_size, &cma_size, &high);
if (ret)
return;
- crash_base = get_crash_base(crash_base);
- crash_end = crash_base + crash_size - 1;
+ if (high && !high_crashkernel_supported()) {
+ high = false;
+ low_size = 0;
+ pr_warn("High crashkernel unsupported, using standard reservation");
+ }
- kernel_start = __pa(_stext);
- kernel_size = _end - _stext;
+ if (high) {
+ crash_base = 0;
+ } else {
+ crash_base = get_crash_base(crash_base);
+ crash_end = crash_base + crash_size - 1;
- /* The crash region must not overlap the current kernel */
- if ((kernel_start + kernel_size > crash_base) && (kernel_start <= crash_end)) {
- pr_warn("Crash kernel can not overlap current kernel\n");
- return;
+ kernel_start = __pa(_stext);
+ kernel_size = _end - _stext;
+
+ /* The crash region must not overlap the current kernel */
+ if ((kernel_start + kernel_size > crash_base) && (kernel_start <= crash_end)) {
+ pr_warn("Crash kernel can not overlap current kernel\n");
+ return;
+ }
}
- reserve_crashkernel_generic(crash_size, crash_base, 0, false);
+ reserve_crashkernel_generic(crash_size, crash_base, low_size, high);
}
void __init kdump_cma_reserve(void)
--
2.51.0
More information about the Linuxppc-dev
mailing list