powerpc/fadump: skip parameter area allocation when fadump is disabled
Hari Bathini
hbathini at linux.ibm.com
Tue Oct 7 21:28:26 AEDT 2025
On 07/10/25 1:10 pm, Sourabh Jain wrote:
> Fadump allocates memory to pass additional kernel command-line argument
> to the fadump kernel. However, this allocation is not needed when fadump
> is disabled. So avoid allocating memory for the additional parameter
> area in such cases.
>
This needs the fixes tag...
Fixes: f4892c68ecc1 ("powerpc/fadump: allocate memory for additional
parameters early")
Otherwise, looks good to me.
Reviewed-by: Hari Bathini <hbathini at linux.ibm.com>
> Cc: Hari Bathini <hbathini at linux.ibm.com>
> Cc: Madhavan Srinivasan <maddy at linux.ibm.com>
> Cc: Michael Ellerman <mpe at ellerman.id.au>
> Signed-off-by: Sourabh Jain <sourabhjain at linux.ibm.com>
> ---
> arch/powerpc/kernel/fadump.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index 5782e743fd27..4ebc333dd786 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -1747,6 +1747,9 @@ void __init fadump_setup_param_area(void)
> {
> phys_addr_t range_start, range_end;
>
> + if (!fw_dump.fadump_enabled)
> + return;
> +
> if (!fw_dump.param_area_supported || fw_dump.dump_active)
> return;
>
More information about the Linuxppc-dev
mailing list