[PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes

Rob Herring robh at kernel.org
Tue Nov 25 05:31:55 AEDT 2025


On Wed, Oct 29, 2025 at 12:41 PM Rob Herring (Arm) <robh at kernel.org> wrote:
>
> Similar to other PowerMac mac-io devices, the media-bay node is missing the
> "#size-cells" property.
>
> Depends-on: commit 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
> Reported-by: Stan Johnson <userm57 at yahoo.com>
> Signed-off-by: Rob Herring (Arm) <robh at kernel.org>
> ---
>  arch/powerpc/kernel/prom_init.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Ping!

>
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 827c958677f8..f26e80cbc615 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -2893,7 +2893,8 @@ static void __init fixup_device_tree_pmac(void)
>         for (node = 0; prom_next_node(&node); ) {
>                 type[0] = '\0';
>                 prom_getprop(node, "device_type", type, sizeof(type));
> -               if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s"))
> +               if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s") &&
> +                   prom_strcmp(type, "media-bay"))
>                         continue;
>
>                 if (prom_getproplen(node, "#size-cells") != PROM_ERROR)
> --
> 2.51.0
>


More information about the Linuxppc-dev mailing list