[PATCH v2 2/3] PCI/PM: Stop needlessly clearing state_saved on enumeration and thaw

[Rafael J. Wysocki]

On Wed, Nov 19, 2025 at 10:02 AM Lukas Wunner <lukas at wunner.de> wrote:
>
> The state_saved flag tells the PCI core whether a driver assumes
> responsibility to save Config Space and put the device into a low power
> state on suspend.
>
> The flag is currently initialized to false on enumeration, even though it
> already is false (because struct pci_dev is zeroed by kzalloc()) and even
> though it is set to false before commencing the suspend sequence (the only
> code path where it's relevant).
>
> The flag is also set to false in pci_pm_thaw(), i.e. on resume, when it's
> no longer relevant.
>
> Drop these two superfluous flag assignments for simplicity.
>
> Signed-off-by: Lukas Wunner <lukas at wunner.de>

Reviewed-by: Rafael J. Wysocki (Intel) <rafael at kernel.org>

> ---
>  drivers/pci/pci-driver.c | 2 --
>  drivers/pci/probe.c      | 2 --
>  2 files changed, 4 deletions(-)
>
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index 327b21c48614..7c2d9d596258 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -1133,8 +1133,6 @@ static int pci_pm_thaw(struct device *dev)
>                 pci_pm_reenable_device(pci_dev);
>         }
>
> -       pci_dev->state_saved = false;
> -
>         return error;
>  }
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index c83e75a0ec12..c7c7a3d5ec0f 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -2747,8 +2747,6 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
>
>         pci_reassigndev_resource_alignment(dev);
>
> -       dev->state_saved = false;
> -
>         pci_init_capabilities(dev);
>
>         /*
> --
> 2.51.0
>
>