ppc/lv1call: Fix PS3 LV1 clobbering SRR

[René Rebe]

Hi,

On Tue, 18 Nov 2025 14:57:25 +0100, Christophe Leroy <christophe.leroy at csgroup.eu> wrote:

> Le 18/11/2025 à 14:42, René Rebe a écrit :
> > [Vous ne recevez pas souvent de courriers de
> > rene at exactco.de. Découvrez pourquoi ceci est important à
> > https://aka.ms/LearnAboutSenderIdentification ]
> > Since a while booting a PS3 instantly yields:
> 
> Can you bisect to say since when, and add a Fixes: tag to the commit ?

I could, but it might take a day, or two. But maybe always, and we
only notice since 6eaaf9de3599865ee3b339d90cb24f2153f40bf4
("powerpc/64s/interrupt: Check and fix srr_valid without crashing")?

Should I use that as a Fixes?

> > <4>SRR0 was: c0000000000971b4 should be: c0000000002d55c4
> > <4>SRR1 was: 8000000000008032 should be: 8000000000008032
> > Fix LV1 clobbering SRR by srr_regs_clobbered() each lv1 call.
> > Attribute srr_regs_clobbered always_inline for use by modules.
> > Signed-off-by: René Rebe <rene at exactco.de>
> > ---
> >   arch/powerpc/include/asm/interrupt.h | 1 +
> >   arch/powerpc/include/asm/lv1call.h   | 3 ++-
> >   2 files changed, 3 insertions(+), 1 deletion(-)
> > diff --git a/arch/powerpc/include/asm/interrupt.h
> > b/arch/powerpc/include/asm/interrupt.h
> > index eb0e4a20b818..783c6f32a395 100644
> > --- a/arch/powerpc/include/asm/interrupt.h
> > +++ b/arch/powerpc/include/asm/interrupt.h
> > @@ -106,6 +106,7 @@ static inline bool is_implicit_soft_masked(struct
> > pt_regs *regs)
> >          return search_kernel_soft_mask_table(regs->nip);
> >   }
> > +__attribute__((always_inline))
> >   static inline void srr_regs_clobbered(void)
> 
> Instead, use:
> 
> 	static __always_inline void srr_regs_clobbered(void)

Of course, happy to v2 as soon as I know of the above Fixes: is good
enough or I should start bisecting to double-check, ...

Merci,
       René

-- 
René Rebe, ExactCODE GmbH, Berlin, Germany
https://exactco.de • https://t2linux.com • https://patreon.com/renerebe