[RFC PATCH v1 3/6] mm: Avoid calling page allocator from apply_to_page_range()
Liam R. Howlett
Liam.Howlett at oracle.com
Sat May 31 05:08:59 AEST 2025
* Ryan Roberts <ryan.roberts at arm.com> [250530 12:50]:
...
> >
> >
> > These wrappers are terrible for readability and annoying for argument
> > lists too.
>
> Agreed.
>
> >
> > Could we do something like the pgtbl_mod_mask or zap_details and pass
> > through a struct or one unsigned int for create and lazy_mmu?
>
> Or just create some enum flags?
>
> >
> > At least we'd have better self-documenting code in the wrappers.. and if
> > we ever need a third boolean, we could avoid multiplying the wrappers
> > again.
> >
> > WDYT?
>
> I'm happy with either approach. I was expecting more constination about the idea
> of being able to disable lazy mode though, so perhaps I'll wait and see if any
> arrives. If it doesn't... flags?
Yes, that works as well. Please use pmd_flags or anything more
descriptive than just 'flags' :)
I wonder which approach is best in asm instructions and self-documenting
code.
Regards,
Liam
More information about the Linuxppc-dev
mailing list