[PATCH 00/12] mm: Remove pXX_devmap page table bit and pfn_t type
Alistair Popple
apopple at nvidia.com
Thu May 29 16:32:01 AEST 2025
Changes from v2 of the RFC[1]:
- My ZONE_DEVICE refcount series has been merged as commit 7851bf649d42 (Patch series
"fs/dax: Fix ZONE_DEVICE page reference counts", v9.) which is included in
v6.15 so have rebased on top of that.
- No major changes required for the rebase other than fixing up a new user of
the pfn_t type (intel_th).
- As a reminder the main benefit of this series is it frees up a PTE bit
(pte_devmap).
- This may be a bit late to consider for inclusion in v6.16 unless it can get
some more reviews before the merge window closes. I don't think missing v6.16
is a huge issue though.
- This passed xfstests for a XFS filesystem with DAX enabled on my system and
as many of the ndctl tests that pass on my system without it.
Changes for v2:
- This is an update to my previous RFC[2] removing just pfn_t rebased
on today's mm-unstable which includes my ZONE_DEVICE refcounting
clean-up.
- The removal of the devmap PTE bit and associated infrastructure was
dropped from that series so I have rolled it into this series.
- Logically this series makes sense to me, but the dropping of devmap
is wide ranging and touches some areas I'm less familiar with so
would definitely appreciate any review comments there.
[1] - https://lore.kernel.org/linux-mm/cover.95ff0627bc727f2bae44bea4c00ad7a83fbbcfac.1739941374.git-series.apopple@nvidia.com/
[2] - https://lore.kernel.org/linux-mm/cover.a7cdeffaaa366a10c65e2e7544285059cc5d55a4.1736299058.git-series.apopple@nvidia.com/
All users of dax now require a ZONE_DEVICE page which is properly
refcounted. This means there is no longer any need for the PFN_DEV, PFN_MAP
and PFN_SPECIAL flags. Furthermore the PFN_SG_CHAIN and PFN_SG_LAST flags
never appear to have been used. It is therefore possible to remove the
pfn_t type and replace any usage with raw pfns.
The remaining users of PFN_DEV have simply passed this to
vmf_insert_mixed() to create pte_devmap() mappings. It is unclear why this
was the case but presumably to ensure vm_normal_page() does not return
these pages. These users can be trivially converted to raw pfns and
creating a pXX_special() mapping to ensure vm_normal_page() still doesn't
return these pages.
Now that there are no users of PFN_DEV we can remove the devmap page table
bit and all associated functions and macros, freeing up a software page
table bit.
---
Cc: gerald.schaefer at linux.ibm.com
Cc: dan.j.williams at intel.com
Cc: jgg at ziepe.ca
Cc: willy at infradead.org
Cc: david at redhat.com
Cc: linux-kernel at vger.kernel.org
Cc: nvdimm at lists.linux.dev
Cc: linux-fsdevel at vger.kernel.org
Cc: linux-mm at kvack.org
Cc: linux-ext4 at vger.kernel.org
Cc: linux-xfs at vger.kernel.org
Cc: jhubbard at nvidia.com
Cc: hch at lst.de
Cc: zhang.lyra at gmail.com
Cc: debug at rivosinc.com
Cc: bjorn at kernel.org
Cc: balbirs at nvidia.com
Cc: lorenzo.stoakes at oracle.com
Cc: linux-arm-kernel at lists.infradead.org
Cc: loongarch at lists.linux.dev
Cc: linuxppc-dev at lists.ozlabs.org
Cc: linux-riscv at lists.infradead.org
Cc: nvdimm at lists.linux.dev
Cc: linux-cxl at vger.kernel.org
Cc: dri-devel at lists.freedesktop.org
Cc: John at Groves.net
Alistair Popple (12):
mm: Remove PFN_MAP, PFN_SG_CHAIN and PFN_SG_LAST
mm: Convert pXd_devmap checks to vma_is_dax
mm/pagewalk: Skip dax pages in pagewalk
mm: Convert vmf_insert_mixed() from using pte_devmap to pte_special
mm: Remove remaining uses of PFN_DEV
mm/gup: Remove pXX_devmap usage from get_user_pages()
mm: Remove redundant pXd_devmap calls
mm/khugepaged: Remove redundant pmd_devmap() check
powerpc: Remove checks for devmap pages and PMDs/PUDs
mm: Remove devmap related functions and page table bits
mm: Remove callers of pfn_t functionality
mm/memremap: Remove unused devmap_managed_key
Documentation/mm/arch_pgtable_helpers.rst | 6 +-
arch/arm64/Kconfig | 1 +-
arch/arm64/include/asm/pgtable-prot.h | 1 +-
arch/arm64/include/asm/pgtable.h | 24 +---
arch/loongarch/Kconfig | 1 +-
arch/loongarch/include/asm/pgtable-bits.h | 6 +-
arch/loongarch/include/asm/pgtable.h | 19 +--
arch/powerpc/Kconfig | 1 +-
arch/powerpc/include/asm/book3s/64/hash-4k.h | 6 +-
arch/powerpc/include/asm/book3s/64/hash-64k.h | 7 +-
arch/powerpc/include/asm/book3s/64/pgtable.h | 53 +------
arch/powerpc/include/asm/book3s/64/radix.h | 14 +--
arch/powerpc/mm/book3s64/hash_hugepage.c | 2 +-
arch/powerpc/mm/book3s64/hash_pgtable.c | 3 +-
arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +-
arch/powerpc/mm/book3s64/pgtable.c | 10 +-
arch/powerpc/mm/book3s64/radix_pgtable.c | 5 +-
arch/powerpc/mm/pgtable.c | 2 +-
arch/riscv/Kconfig | 1 +-
arch/riscv/include/asm/pgtable-64.h | 20 +--
arch/riscv/include/asm/pgtable-bits.h | 1 +-
arch/riscv/include/asm/pgtable.h | 17 +--
arch/x86/Kconfig | 1 +-
arch/x86/include/asm/pgtable.h | 51 +------
arch/x86/include/asm/pgtable_types.h | 5 +-
arch/x86/mm/pat/memtype.c | 6 +-
drivers/dax/device.c | 23 +--
drivers/dax/hmem/hmem.c | 1 +-
drivers/dax/kmem.c | 1 +-
drivers/dax/pmem.c | 1 +-
drivers/dax/super.c | 3 +-
drivers/gpu/drm/exynos/exynos_drm_gem.c | 1 +-
drivers/gpu/drm/gma500/fbdev.c | 3 +-
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 1 +-
drivers/gpu/drm/msm/msm_gem.c | 1 +-
drivers/gpu/drm/omapdrm/omap_gem.c | 7 +-
drivers/gpu/drm/v3d/v3d_bo.c | 1 +-
drivers/hwtracing/intel_th/msu.c | 3 +-
drivers/md/dm-linear.c | 2 +-
drivers/md/dm-log-writes.c | 2 +-
drivers/md/dm-stripe.c | 2 +-
drivers/md/dm-target.c | 2 +-
drivers/md/dm-writecache.c | 11 +-
drivers/md/dm.c | 2 +-
drivers/nvdimm/pmem.c | 8 +-
drivers/nvdimm/pmem.h | 4 +-
drivers/s390/block/dcssblk.c | 10 +-
drivers/vfio/pci/vfio_pci_core.c | 7 +-
fs/cramfs/inode.c | 5 +-
fs/dax.c | 55 ++----
fs/ext4/file.c | 2 +-
fs/fuse/dax.c | 3 +-
fs/fuse/virtio_fs.c | 5 +-
fs/userfaultfd.c | 2 +-
fs/xfs/xfs_file.c | 2 +-
include/linux/dax.h | 9 +-
include/linux/device-mapper.h | 2 +-
include/linux/huge_mm.h | 19 +--
include/linux/memremap.h | 11 +-
include/linux/mm.h | 11 +-
include/linux/pfn.h | 9 +-
include/linux/pfn_t.h | 131 +---------------
include/linux/pgtable.h | 25 +---
include/trace/events/fs_dax.h | 12 +-
mm/Kconfig | 4 +-
mm/debug_vm_pgtable.c | 60 +-------
mm/gup.c | 162 +-------------------
mm/hmm.c | 12 +-
mm/huge_memory.c | 97 ++---------
mm/khugepaged.c | 2 +-
mm/madvise.c | 8 +-
mm/mapping_dirty_helpers.c | 4 +-
mm/memory.c | 64 ++------
mm/memremap.c | 28 +---
mm/migrate.c | 1 +-
mm/migrate_device.c | 2 +-
mm/mprotect.c | 2 +-
mm/mremap.c | 5 +-
mm/page_vma_mapped.c | 5 +-
mm/pagewalk.c | 20 +-
mm/pgtable-generic.c | 7 +-
mm/userfaultfd.c | 6 +-
mm/vmscan.c | 5 +-
tools/testing/nvdimm/pmem-dax.c | 6 +-
tools/testing/nvdimm/test/iomap.c | 11 +-
tools/testing/nvdimm/test/nfit_test.h | 1 +-
86 files changed, 218 insertions(+), 958 deletions(-)
delete mode 100644 include/linux/pfn_t.h
base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21
--
git-series 0.9.1
More information about the Linuxppc-dev
mailing list